tools: add and apply eslint rule no-regex-spaces#26409
tools: add and apply eslint rule no-regex-spaces#26409gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
57b8e13 to
7c882c3
Compare
|
Personally, I find this less readable. |
|
My main thought is that:
But I am not quite insistent on this. If most @nodejs/lint members not a a fan of this rule, I will drop this pr (Not quite sure how to start a poll, use emoji ?). |
I'd rather we have discussions and avoid polls (meaning that one person giving a good reason for doing or not doing something is better than a dozen people saying "+1" or "-1".). I'd prefer we don't do this. My feelings aren't strong enough to block it, but:
That said, I think a few of these would benefit from being changed from regular expressions to calls to |
|
@Trott Most cases involved in this rule looks like can be done using snapshot test (something like https://jestjs.io/docs/en/snapshot-testing). Maybe a different issue though. I will close this. |
Expert from https://eslint.org/docs/rules/no-regex-spaces:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes